Преглед на файлове

Merge pull request #66 from rauls5382/pprofbinarypathmsg

Add a message recommending the use of PPROF_BINARY_PATH
Raul Silvera преди 8 години
родител
ревизия
45800b2f47
променени са 1 файла, в които са добавени 4 реда и са изтрити 3 реда
  1. 4
    3
      internal/symbolizer/symbolizer.go

+ 4
- 3
internal/symbolizer/symbolizer.go Целия файл

290
 
290
 
291
 		if m.File == "" {
291
 		if m.File == "" {
292
 			if midx == 0 {
292
 			if midx == 0 {
293
-				ui.PrintErr("Main binary filename not available.\n" +
294
-					"Try passing the path to the main binary before the profile.")
293
+				ui.PrintErr("Main binary filename not available.")
295
 				continue
294
 				continue
296
 			}
295
 			}
297
 			missingBinaries = true
296
 			missingBinaries = true
314
 		f, err := obj.Open(m.File, m.Start, m.Limit, m.Offset)
313
 		f, err := obj.Open(m.File, m.Start, m.Limit, m.Offset)
315
 		if err != nil {
314
 		if err != nil {
316
 			ui.PrintErr("Local symbolization failed for ", name, ": ", err)
315
 			ui.PrintErr("Local symbolization failed for ", name, ": ", err)
316
+			missingBinaries = true
317
 			continue
317
 			continue
318
 		}
318
 		}
319
 		if fid := f.BuildID(); m.BuildID != "" && fid != "" && fid != m.BuildID {
319
 		if fid := f.BuildID(); m.BuildID != "" && fid != "" && fid != m.BuildID {
325
 		mt.segments[m] = f
325
 		mt.segments[m] = f
326
 	}
326
 	}
327
 	if missingBinaries {
327
 	if missingBinaries {
328
-		ui.PrintErr("Some binary filenames not available. Symbolization may be incomplete.")
328
+		ui.PrintErr("Some binary filenames not available. Symbolization may be incomplete.\n" +
329
+			"Try setting PPROF_BINARY_PATH to the search path for local binaries.")
329
 	}
330
 	}
330
 	return mt, nil
331
 	return mt, nil
331
 }
332
 }