浏览代码

Merge pull request #66 from rauls5382/pprofbinarypathmsg

Add a message recommending the use of PPROF_BINARY_PATH
Raul Silvera 8 年前
父节点
当前提交
45800b2f47
共有 1 个文件被更改,包括 4 次插入3 次删除
  1. 4
    3
      internal/symbolizer/symbolizer.go

+ 4
- 3
internal/symbolizer/symbolizer.go 查看文件

@@ -290,8 +290,7 @@ func newMapping(prof *profile.Profile, obj plugin.ObjTool, ui plugin.UI, force b
290 290
 
291 291
 		if m.File == "" {
292 292
 			if midx == 0 {
293
-				ui.PrintErr("Main binary filename not available.\n" +
294
-					"Try passing the path to the main binary before the profile.")
293
+				ui.PrintErr("Main binary filename not available.")
295 294
 				continue
296 295
 			}
297 296
 			missingBinaries = true
@@ -314,6 +313,7 @@ func newMapping(prof *profile.Profile, obj plugin.ObjTool, ui plugin.UI, force b
314 313
 		f, err := obj.Open(m.File, m.Start, m.Limit, m.Offset)
315 314
 		if err != nil {
316 315
 			ui.PrintErr("Local symbolization failed for ", name, ": ", err)
316
+			missingBinaries = true
317 317
 			continue
318 318
 		}
319 319
 		if fid := f.BuildID(); m.BuildID != "" && fid != "" && fid != m.BuildID {
@@ -325,7 +325,8 @@ func newMapping(prof *profile.Profile, obj plugin.ObjTool, ui plugin.UI, force b
325 325
 		mt.segments[m] = f
326 326
 	}
327 327
 	if missingBinaries {
328
-		ui.PrintErr("Some binary filenames not available. Symbolization may be incomplete.")
328
+		ui.PrintErr("Some binary filenames not available. Symbolization may be incomplete.\n" +
329
+			"Try setting PPROF_BINARY_PATH to the search path for local binaries.")
329 330
 	}
330 331
 	return mt, nil
331 332
 }