* Check if location has a line with empty function

* Include context in the error message that will help triage the error

This is similar to such flag in driver_test.go and dotgraph_test.go.

I had this change locally for some time, would like to check this in.

Fix comments according to best practices by effective go

Signed-off-by: CodeLingo Bot <bot@codelingo.io>

This change detects concatenated profiles by checking if time_nanos appears more than once in the profile being parsed.

Fixes #273

* Support parsing of is_folded bit

* Include folded bit lin (*Location).string() and in profile mergining

* address comments

* Set IsFolded to false during symbolization when Line is reset

* simplify tests

* Fix panic on merge when one profile missing mappings

* Simplify fix for merge panics

Add tests for CheckValid, fix a couple crashers.

* Add support for tag units

Updated tests for adding tag units

* updated proto docs to describe tag units

* fixed formatting

* added additional test

* require specific units for graph tag to be recognixed

* updated tests and formatting

* Fixed formatting

* Fixed style error

* modify proto_test to be sure tag units not overwritten

* Clarified label docs

* call legacy profile memory allocations size, not byte

* updated tests to call bytes tags in legacy profile size

* Revert "updated tests to call bytes tags in legacy profile size"

This reverts commit 9289378af2.

* Revert "call legacy profile memory allocations size, not byte"

This reverts commit 6b18973562.

* Updated so units not modified when profile written out

* Fixed formatting errors

* Removed field for inferred numeric label units from profile

* Modified profile String() output

* fixed formatting error

* changed name of function used to identify units for numeric labels

* Refactor String() for profile

* Modified for clarity and address comments

* renamed function for clarity

* Made numeric label units field seperate in profile

* Modified test

* Refactored identifyNumLabelUnits()

* Updated comments

* Fixed formatting error

* Addressed comments

* Fixed style error

* clarify comment

* Refactored to address comments

* addressed comments

* addressed comments

* addressed comments

Added some multi-threaded tests that allow the race detector
to detect race conditions in pprof internals.

FilterSamplesByName should return true for hnm only when
"at least one sample" matched the show regexp.
Before this commit it always returned true
if the show regexp is not nil and p.Location is not empty.

* `git ls-files -- '*.go' | xargs gofmt -s -w`

* driver: unexport InternalOptions

This was an exported method that returned an internal type, so it's
unlikely that anyone depends on its presence.

* internal/binutils: remove newline in error string

golint reported: error strings should not be capitalized or end with
punctuation or a newline

* internal/driver: s/buildId/buildID/ per golint

* internal/elfexec: remove punctuation in error string

golint reported: error strings should not be capitalized or end with
punctuation or a newline

* internal/graph: correct comment

Found with golint.

* internal/graph: add method comment

golint reported: exported method Edge.WeightValue should have comment
or be unexported

* internal/report: remove newline in error string

golint reported: error strings should not be capitalized or end with
punctuation or a newline

* *: remove unused code

Found with honnef.co/go/tools/cmd/unused:

	internal/binutils/disasm_test.go:137:8: const objdump is unused (U1000)
	internal/driver/driver_test.go:353:6: type testProfile is unused (U1000)
	internal/graph/graph.go:838:6: func countEdges is unused (U1000)
	profile/proto.go:148:6: func encodeStringOpt is unused (U1000)

* *: simply code

Found with honnef.co/go/tools/cmd/gosimple:

	internal/driver/commands.go:471:24: should omit comparison to bool constant, can be simplified to !b (S1002)
	internal/driver/driver.go:163:5: should omit comparison to bool constant, can be simplified to !trim (S1002)
	internal/driver/driver.go:168:5: should omit comparison to bool constant, can be simplified to !focus (S1002)
	internal/driver/driver.go:172:5: should omit comparison to bool constant, can be simplified to !tagfocus (S1002)
	internal/driver/driver.go:176:5: should omit comparison to bool constant, can be simplified to !hide (S1002)
	internal/graph/dotgraph.go:213:34: should use make(map[string][]*Tag) instead (S1019)
	internal/report/report.go:1061:3: should replace loop with label = append(label, rpt.options.ProfileLabels...) (S1011)
	profile/proto.go:157:5: should omit comparison to bool constant, can be simplified to !x (S1002)

* *: correct mistakes

Found with honnef.co/go/tools/cmd/staticcheck:

	driver/driver.go:280:20: infinite recursive call (SA5007)
	internal/driver/driver_focus.go:54:11: this value of err is never used (SA4006)
	profile/proto.go:74:32: x | 0 always equals x (SA4016)

* Add linters to .travis.yml

Simplify regexps and define a recommended format:
  Start   End     object file name     offset(optional)   linker build id
  0x40000-0x80000 /path/to/binary      (@FF00)            abc123456

Also include some additional tests and move existing tests to legacy_profile_test.go,
closer to the code in legacy_profile.go.

A previous commit tried to eliminate a panic when reading an empty
profile by stopping support for profiles with no samples. That is
unnecessary and it can obstruct some testing.

The panic was caused by the legacy parser returning a nil profile and
no error when processing an empty profile. Detect that situation and
generate a proper profile instead.

Tested by running 'pprof /dev/null'
Add testcase for profile parsing errors

- Remove dead code, unnecessary conversions
- Consistently use a single space after period

Also update the build instructions to use go get