Remove unused subset of the flagset interface. (#508)

driver/driver.go

@@ -92,13 +92,6 @@ type FlagSet interface {
 	Float64(name string, def float64, usage string) *float64
 	String(name string, def string, usage string) *string
 
-	// BoolVar, IntVar, Float64Var, and StringVar define new flags referencing
-	// a given pointer, like the functions of the same name in package flag.
-	BoolVar(pointer *bool, name string, def bool, usage string)
-	IntVar(pointer *int, name string, def int, usage string)
-	Float64Var(pointer *float64, name string, def float64, usage string)
-	StringVar(pointer *string, name string, def string, usage string)
-
 	// StringList is similar to String but allows multiple values for a
 	// single flag
 	StringList(name string, def string, usage string) *[]*string

internal/driver/driver_test.go

@@ -330,38 +330,6 @@ func (f testFlags) String(s, d, c string) *string {
 	return &d
 }
 
-func (f testFlags) BoolVar(p *bool, s string, d bool, c string) {
-	if b, ok := f.bools[s]; ok {
-		*p = b
-	} else {
-		*p = d
-	}
-}
-
-func (f testFlags) IntVar(p *int, s string, d int, c string) {
-	if i, ok := f.ints[s]; ok {
-		*p = i
-	} else {
-		*p = d
-	}
-}
-
-func (f testFlags) Float64Var(p *float64, s string, d float64, c string) {
-	if g, ok := f.floats[s]; ok {
-		*p = g
-	} else {
-		*p = d
-	}
-}
-
-func (f testFlags) StringVar(p *string, s, d, c string) {
-	if t, ok := f.strings[s]; ok {
-		*p = t
-	} else {
-		*p = d
-	}
-}
-
 func (f testFlags) StringList(s, d, c string) *[]*string {
 	if t, ok := f.stringLists[s]; ok {
 		// convert slice of strings to slice of string pointers before returning.

internal/driver/flags.go

@@ -44,27 +44,6 @@ func (*GoFlags) String(o, d, c string) *string {
 	return flag.String(o, d, c)
 }
 
-// BoolVar implements the plugin.FlagSet interface.
-func (*GoFlags) BoolVar(b *bool, o string, d bool, c string) {
-	flag.BoolVar(b, o, d, c)
-}
-
-// IntVar implements the plugin.FlagSet interface.
-func (*GoFlags) IntVar(i *int, o string, d int, c string) {
-	flag.IntVar(i, o, d, c)
-}
-
-// Float64Var implements the plugin.FlagSet interface.
-// the value of the flag.
-func (*GoFlags) Float64Var(f *float64, o string, d float64, c string) {
-	flag.Float64Var(f, o, d, c)
-}
-
-// StringVar implements the plugin.FlagSet interface.
-func (*GoFlags) StringVar(s *string, o, d, c string) {
-	flag.StringVar(s, o, d, c)
-}
-
 // StringList implements the plugin.FlagSet interface.
 func (*GoFlags) StringList(o, d, c string) *[]*string {
 	return &[]*string{flag.String(o, d, c)}

internal/plugin/plugin.go

@@ -61,13 +61,6 @@ type FlagSet interface {
 	Float64(name string, def float64, usage string) *float64
 	String(name string, def string, usage string) *string
 
-	// BoolVar, IntVar, Float64Var, and StringVar define new flags referencing
-	// a given pointer, like the functions of the same name in package flag.
-	BoolVar(pointer *bool, name string, def bool, usage string)
-	IntVar(pointer *int, name string, def int, usage string)
-	Float64Var(pointer *float64, name string, def float64, usage string)
-	StringVar(pointer *string, name string, def string, usage string)
-
 	// StringList is similar to String but allows multiple values for a
 	// single flag
 	StringList(name string, def string, usage string) *[]*string