When the source is remote and a mapping doesn't have either build ID or file field set, the file field is set to the source URL so that the proper source from the source mapping is used during symbolz processing. Before this change, the file field would continue to point to the URL producing the URL in pprof output which confuses users. With the change it resets the file field back to the empty string. It also now skips the URL-like paths during local symbolization as reading at that path is not going to succeed. We discussed switching to generating more unique IDs. On the second thought, I propose leaving these to be URLs as that seems unique enough and in case this field leaks into the tool or log output seeing the URL seems still friendlier than some arbitrarily prefixed string.
|
|
||
72 |
|
72 |
|
73 |
|
73 |
|
74 |
|
74 |
|
|
75 |
|
|
75 |
|
76 |
|
76 |
|
77 |
|
77 |
|
78 |
|
|
|
||
283 |
|
284 |
|
284 |
|
285 |
|
285 |
|
286 |
|
|
287 |
|
|
|
288 |
|
|
286 |
|
289 |
|
287 |
|
290 |
|
288 |
|
291 |
|
|
|
||
291 |
|
294 |
|
292 |
|
295 |
|
293 |
|
296 |
|
|
297 |
|
|
|
298 |
|
|
|
299 |
|
|
|
300 |
|
|
|
301 |
|
|
|
302 |
|
|
|
303 |
|
|
|
304 |
|
|
|
305 |
|
|
|
306 |
|
|
|
307 |
|
|
|
308 |
|
|
294 |
|
309 |
|
295 |
|
310 |
|
296 |
|
311 |
|
|
|
||
21 |
|
21 |
|
22 |
|
22 |
|
23 |
|
23 |
|
|
24 |
|
|
24 |
|
25 |
|
25 |
|
26 |
|
26 |
|
27 |
|
|
|
||
76 |
|
77 |
|
77 |
|
78 |
|
78 |
|
79 |
|
|
80 |
|
|
|
81 |
|
|
|
82 |
|
|
|
83 |
|
|
|
84 |
|
|
|
85 |
|
|
|
86 |
|
|
|
87 |
|
|
|
88 |
|
|
|
89 |
|
|
|
90 |
|
|
|
91 |
|
|
|
92 |
|
|
|
93 |
|
|
|
94 |
|
|
|
95 |
|
|
|
96 |
|
|
|
97 |
|
|
|
98 |
|
|
|
99 |
|
|
|
100 |
|
|
|
101 |
|
|
|
102 |
|
|
|
103 |
|
|
|
104 |
|
|
|
105 |
|
|
|
106 |
|
|
|
107 |
|
|
|
108 |
|
|
|
109 |
|
|
|
110 |
|
|
|
111 |
|
|
|
112 |
|
|
|
113 |
|
|
|
114 |
|
|
|
115 |
|
|
|
116 |
|
|
|
117 |
|
|
|
118 |
|
|
|
119 |
|
|
|
120 |
|
|
|
121 |
|
|
|
122 |
|
|
|
123 |
|
|
|
124 |
|
|
|
125 |
|
|
|
126 |
|
|
|
127 |
|
|
|
128 |
|
|
79 |
|
129 |
|
80 |
|
130 |
|
81 |
|
131 |
|
|
|
||
125 |
|
175 |
|
126 |
|
176 |
|
127 |
|
177 |
|
|
178 |
|
|
|
179 |
|
|
|
180 |
|
|
|
181 |
|
|
|
182 |
|
|
|
183 |
|
|
|
184 |
|
|
|
185 |
|
|
|
186 |
|
|
|
187 |
|
|
|
188 |
|
|
|
189 |
|
|
128 |
|
190 |
|
129 |
|
191 |
|
130 |
|
192 |
|
|
|
||
21 |
|
21 |
|
22 |
|
22 |
|
23 |
|
23 |
|
|
24 |
|
|
24 |
|
25 |
|
25 |
|
26 |
|
26 |
|
27 |
|
|
|
||
299 |
|
300 |
|
300 |
|
301 |
|
301 |
|
302 |
|
|
303 |
|
|
|
304 |
|
|
|
305 |
|
|
|
306 |
|
|
|
307 |
|
|
|
308 |
|
|
|
309 |
|
|
302 |
|
310 |
|
303 |
|
311 |
|
304 |
|
312 |
|