Script to generate binutils test binaries for MacOS and Linux (#452)

internal/binutils/binutils_test.go

@@ -218,6 +218,9 @@ func findSymbol(syms []*plugin.Sym, name string) *plugin.Sym {
 }
 
 func TestObjFile(t *testing.T) {
+	// If this test fails, check the address for main function in testdata/exe_linux_64
+	// using the command 'nm -n '. Update the hardcoded addresses below to match
+	// the addresses from the output.
 	skipUnlessLinuxAmd64(t)
 	for _, tc := range []struct {
 		desc                 string
@@ -264,6 +267,9 @@ func TestObjFile(t *testing.T) {
 }
 
 func TestMachoFiles(t *testing.T) {
+	// If this test fails, check the address for main function in testdata/exe_mac_64
+	// and testdata/lib_mac_64 using addr2line or gaddr2line. Update the
+	// hardcoded addresses below to match the addresses from the output.
 	skipUnlessDarwinAmd64(t)
 
 	// Load `file`, pretending it was mapped at `start`. Then get the symbol

internal/binutils/testdata/build_binaries.sh

@@ -0,0 +1,58 @@
+#!/bin/bash -x
+
+# Copyright 2019 Google Inc. All Rights Reserved.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+# This is a script that generates the test executables for MacOS and Linux
+# in this directory. It should be needed very rarely to run this script.
+# It is mostly provided as a future reference on how the original binary
+# set was created.
+
+# When a new executable is generated, hardcoded addresses in the
+# functions TestObjFile, TestMachoFiles in binutils_test.go must be updated.
+
+set -o errexit
+
+cat <<EOF >/tmp/hello.c
+#include <stdio.h>
+
+int main() {
+  printf("Hello, world!\n");
+  return 0;
+}
+EOF
+
+cd $(dirname $0)
+
+if [[ "$OSTYPE" == "linux-gnu" ]]; then
+  rm -rf exe_linux_64*
+  cc -g -o exe_linux_64 /tmp/hello.c
+elif [[ "$OSTYPE" == "darwin"* ]]; then
+  cat <<EOF >/tmp/lib.c
+  int foo() {
+    return 1;
+  }
+
+  int bar() {
+    return 2;
+  }
+  EOF
+
+  rm -rf exe_mac_64* lib_mac_64*
+  clang -g -o exe_mac_64 /tmp/hello.c
+  clang -g -o lib_mac_64 -dynamiclib /tmp/lib.ca
+else
+  echo "Unknown OS: $OSTYPE"
+  exit 1
+fi

internal/binutils/testdata/build_mac.sh

@@ -1,45 +0,0 @@
-# Copyright 2018 Google Inc. All Rights Reserved.
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#     http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-
-#!/bin/bash -x
-
-# This is a script that generates the test MacOS executables in this directory.
-# It should be needed very rarely to run this script. It is mostly provided
-# as a future reference on how the original binary set was created.
-
-set -o errexit
-
-cat <<EOF >/tmp/hello.cc
-#include <stdio.h>
-
-int main() {
-  printf("Hello, world!\n");
-  return 0;
-}
-EOF
-
-cat <<EOF >/tmp/lib.c
-int foo() {
-  return 1;
-}
-
-int bar() {
-  return 2;
-}
-EOF
-
-cd $(dirname $0)
-rm -rf exe_mac_64* lib_mac_64*
-clang -g -o exe_mac_64 /tmp/hello.c
-clang -g -o lib_mac_64 -dynamiclib /tmp/lib.c