Pārlūkot izejas kodu

internal/driver: skip TestHttpsInsecure test on iOS (#256)

This will in turn fix golang.org/issues/22612 for the Go iOS
builders.
Elias Naur 7 gadus atpakaļ
vecāks
revīzija
9e20b5b106
1 mainītis faili ar 13 papildinājumiem un 2 dzēšanām
  1. 13
    2
      internal/driver/fetch_test.go

+ 13
- 2
internal/driver/fetch_test.go Parādīt failu

@@ -411,9 +411,14 @@ func TestHttpsInsecure(t *testing.T) {
411 411
 		Timeout:   10,
412 412
 		Symbolize: "remote",
413 413
 	}
414
+	rx := "Saved profile in"
415
+	if runtime.GOOS == "darwin" && (runtime.GOARCH == "arm" || runtime.GOARCH == "arm64") {
416
+		// On iOS, $HOME points to the app root directory and is not writable.
417
+		rx += "|Could not use temp dir"
418
+	}
414 419
 	o := &plugin.Options{
415 420
 		Obj: &binutils.Binutils{},
416
-		UI:  &proftest.TestUI{T: t, AllowRx: "Saved profile in"},
421
+		UI:  &proftest.TestUI{T: t, AllowRx: rx},
417 422
 	}
418 423
 	o.Sym = &symbolizer.Symbolizer{Obj: o.Obj, UI: o.UI}
419 424
 	p, err := fetchProfiles(s, o)
@@ -423,9 +428,15 @@ func TestHttpsInsecure(t *testing.T) {
423 428
 	if len(p.SampleType) == 0 {
424 429
 		t.Fatalf("fetchProfiles(%s) got empty profile: len(p.SampleType)==0", address)
425 430
 	}
426
-	if runtime.GOOS == "plan9" {
431
+	switch runtime.GOOS {
432
+	case "plan9":
427 433
 		// CPU profiling is not supported on Plan9; see golang.org/issues/22564.
428 434
 		return
435
+	case "darwin":
436
+		if runtime.GOARCH == "arm" || runtime.GOARCH == "arm64" {
437
+			// CPU profiling on iOS os not symbolized; see golang.org/issues/22612.
438
+			return
439
+		}
429 440
 	}
430 441
 	if len(p.Function) == 0 {
431 442
 		t.Fatalf("fetchProfiles(%s) got non-symbolized profile: len(p.Function)==0", address)