Преглед на файлове

Makes TrimTree have no return type

Wade Simba Khadder преди 8 години
родител
ревизия
928d30ac27
променени са 2 файла, в които са добавени 3 реда и са изтрити 4 реда
  1. 1
    2
      internal/graph/graph.go
  2. 2
    2
      internal/report/report.go

+ 1
- 2
internal/graph/graph.go Целия файл

@@ -337,7 +337,7 @@ func newTree(prof *profile.Profile, o *Options) (g *Graph) {
337 337
 
338 338
 // Trims a Graph that is in forest form to contain only the nodes in kept. This
339 339
 // will not work correctly in the case that a node has multiple parents.
340
-func (g *Graph) TrimTree(kept NodeSet) *Graph {
340
+func (g *Graph) TrimTree(kept NodeSet) {
341 341
 	// Creates a new list of nodes
342 342
 	oldNodes := g.Nodes
343 343
 	g.Nodes = make(Nodes, 0, len(kept.Ptr))
@@ -387,7 +387,6 @@ func (g *Graph) TrimTree(kept NodeSet) *Graph {
387 387
 		}
388 388
 	}
389 389
 	g.RemoveRedundantEdges()
390
-	return g
391 390
 }
392 391
 
393 392
 func joinLabels(s *profile.Sample) string {

+ 2
- 2
internal/report/report.go Целия файл

@@ -89,7 +89,7 @@ func (rpt *Report) newTrimmedGraph() (g *graph.Graph, origCount, droppedNodes, d
89 89
 		if nodesKept := g.DiscardLowFrequencyNodes(nodeCutoff); len(g.Nodes) != len(nodesKept.Ptr) {
90 90
 			droppedNodes = len(g.Nodes) - len(nodesKept.Ptr)
91 91
 			if o.CallTree {
92
-				g = g.TrimTree(nodesKept)
92
+				g.TrimTree(nodesKept)
93 93
 			} else {
94 94
 				g = rpt.newGraph(nodesKept)
95 95
 			}
@@ -106,7 +106,7 @@ func (rpt *Report) newTrimmedGraph() (g *graph.Graph, origCount, droppedNodes, d
106 106
 		g.TrimLowFrequencyEdges(edgeCutoff)
107 107
 		if nodesKept := g.SelectTopNodes(nodeCount, visualMode); len(nodesKept.Ptr) != len(g.Nodes) {
108 108
 			if o.CallTree {
109
-				g = g.TrimTree(nodesKept)
109
+				g.TrimTree(nodesKept)
110 110
 			} else {
111 111
 				g = rpt.newGraph(nodesKept)
112 112
 			}