Browse Source

fix accidental closure on parent testing.T. (#470)

Margaret Nolan 6 years ago
parent
commit
8358a9778b
1 changed files with 3 additions and 3 deletions
  1. 3
    3
      internal/driver/driver_test.go

+ 3
- 3
internal/driver/driver_test.go View File

1154
 		},
1154
 		},
1155
 	}
1155
 	}
1156
 	for _, test := range tagFilterTests {
1156
 	for _, test := range tagFilterTests {
1157
-		t.Run(test.desc, func(*testing.T) {
1157
+		t.Run(test.desc, func(t *testing.T) {
1158
 			filter, err := compileTagFilter(test.desc, test.value, nil, &proftest.TestUI{T: t}, nil)
1158
 			filter, err := compileTagFilter(test.desc, test.value, nil, &proftest.TestUI{T: t}, nil)
1159
 			if err != nil {
1159
 			if err != nil {
1160
 				t.Fatalf("tagFilter %s:%v", test.desc, err)
1160
 				t.Fatalf("tagFilter %s:%v", test.desc, err)
1280
 		},
1280
 		},
1281
 	}
1281
 	}
1282
 	for _, test := range tagFilterTests {
1282
 	for _, test := range tagFilterTests {
1283
-		t.Run(test.desc, func(*testing.T) {
1283
+		t.Run(test.desc, func(t *testing.T) {
1284
 			p := profile.Profile{Sample: make([]*profile.Sample, len(test.tagVals))}
1284
 			p := profile.Profile{Sample: make([]*profile.Sample, len(test.tagVals))}
1285
 			for i, numLabel := range test.tagVals {
1285
 			for i, numLabel := range test.tagVals {
1286
 				s := profile.Sample{
1286
 				s := profile.Sample{
1457
 		},
1457
 		},
1458
 	}
1458
 	}
1459
 	for _, test := range tagFilterTests {
1459
 	for _, test := range tagFilterTests {
1460
-		t.Run(test.desc, func(*testing.T) {
1460
+		t.Run(test.desc, func(t *testing.T) {
1461
 			wantErrMsg := strings.Join([]string{"(", test.desc, ":Interpreted '", test.value[strings.Index(test.value, "=")+1:], "' as range, not regexp", ")"}, "")
1461
 			wantErrMsg := strings.Join([]string{"(", test.desc, ":Interpreted '", test.value[strings.Index(test.value, "=")+1:], "' as range, not regexp", ")"}, "")
1462
 			filter, err := compileTagFilter(test.desc, test.value, test.identifiedUnits, &proftest.TestUI{T: t,
1462
 			filter, err := compileTagFilter(test.desc, test.value, test.identifiedUnits, &proftest.TestUI{T: t,
1463
 				AllowRx: wantErrMsg}, nil)
1463
 				AllowRx: wantErrMsg}, nil)