Make TestHttpsInsecure test reliably passing on Darwin. (#171)

* Make TestHttpsInsecure test reliably passing on Darwin.

TestHttpsInsecure test runs a profiling session and checks that the
results contain expected function name. On OSX prior to 10.11 El Capitan
the SIGPROF signal is delivered to the process rather than to the thread
which skews the results enough for the test to fail.

Relax the check when running on OSX and other operating systems known to
have issues with the profiling signal (the list is taken from
src/runtime/pprof/pprof_test.go in Go source).

Also add the multiple variants of OSX to the continuous testing.

Fixes #146 and #156.

* Document the motivation for the empty loop.

.travis.yml

@@ -1,14 +1,33 @@
 language: go
-go:
-  - 1.7.x
-  - 1.8.x
-  - master
 
 go_import_path: github.com/google/pprof
 
-os:
-  - linux
-  - osx
+matrix:
+  include:
+    - os: linux
+      go: 1.7.x
+    - os: linux
+      go: 1.8.x
+    - os: linux
+      go: master
+    - os: osx
+      osx_image: xcode6.4
+      go: 1.8.x
+    - os: osx
+      osx_image: xcode6.4
+      go: master
+    - os: osx
+      osx_image: xcode7.3
+      go: 1.8.x
+    - os: osx
+      osx_image: xcode7.3
+      go: master
+    - os: osx
+      osx_image: xcode8.3
+      go: 1.8.x
+    - os: osx
+      osx_image: xcode8.3
+      go: master
 
 addons:
   apt:

internal/driver/fetch_test.go

@@ -381,7 +381,12 @@ func TestHttpsInsecure(t *testing.T) {
 	go func() {
 		deadline := time.Now().Add(5 * time.Second)
 		for time.Now().Before(deadline) {
-			// Simulate a hotspot function.
+			// Simulate a hotspot function. Spin in the inner loop for 100M iterations
+			// to ensure we get most of the samples landed here rather than in the
+			// library calls. We assume Go compiler won't elide the empty loop.
+			for i := 0; i < 1e8; i++ {
+			}
+			runtime.Gosched()
 		}
 	}()
 
@@ -409,13 +414,24 @@ func TestHttpsInsecure(t *testing.T) {
 		t.Fatal(err)
 	}
 	if len(p.SampleType) == 0 {
-		t.Fatalf("grabProfile(%s) got empty profile: len(p.SampleType)==0", address)
+		t.Fatalf("fetchProfiles(%s) got empty profile: len(p.SampleType)==0", address)
+	}
+	if len(p.Function) == 0 {
+		t.Fatalf("fetchProfiles(%s) got non-symbolized profile: len(p.Function)==0", address)
 	}
-	if err := checkProfileHasFunction(p, "TestHttpsInsecure"); err != nil {
-		t.Fatalf("grabProfile(%s) %v", address, err)
+	if err := checkProfileHasFunction(p, "TestHttpsInsecure"); !badSigprofOS[runtime.GOOS] && err != nil {
+		t.Fatalf("fetchProfiles(%s) %v", address, err)
 	}
 }
 
+// Some operating systems don't trigger the profiling signal right.
+// See https://github.com/golang/go/issues/13841.
+var badSigprofOS = map[string]bool{
+	"darwin": true,
+	"netbsd": true,
+	"plan9":  true,
+}
+
 func checkProfileHasFunction(p *profile.Profile, fname string) error {
 	for _, f := range p.Function {
 		if strings.Contains(f.Name, fname) {