Update tree structure to follow Go conventions

Also update the build instructions to use go get

COMPILE.sh

@@ -1,30 +0,0 @@
-#!/bin/bash
-
-# Copyright 2014 Google Inc. All Rights Reserved.
-# 
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-# 
-#     http://www.apache.org/licenses/LICENSE-2.0
-# 
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-
-ROOT=${PWD}
-
-echo Building pprof at ${ROOT}
-GOPATH=${ROOT}:${ROOT}/third_party go build pprof 
-RETCODE=$?
-
-if [ ${RETCODE} -eq 0 ]
-then
-   echo Build was successful. pprof available at ${ROOT}/pprof
-else
-   echo Build failed.
-   exit 1
-fi
-

README.md

@@ -24,12 +24,16 @@ them through the use of the native binutils tools (addr2line and nm).
 
 Prerequisites:
 
-- Go development kit: https://golang.org/dl/
-  Known to work with Go 1.5
+- Go development kit. Known to work with Go 1.5.
+  Follow [these instructions](http://golang.org/doc/code.html) to install the 
+  go tool and set up GOPATH.
+
 - Graphviz: http://www.graphviz.org/
   Optional, used to generate graphic visualizations of profiles
 
-To build it, run the COMPILE.sh script. The TEST.sh script runs unit tests.
+To build and install it, use the `go get` tool.
+
+    go get github.com/google/pprof
 
 # Basic usage
 

TEST.sh

@@ -1,30 +0,0 @@
-#!/bin/bash
-
-# Copyright 2014 Google Inc. All Rights Reserved.
-# 
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-# 
-#     http://www.apache.org/licenses/LICENSE-2.0
-# 
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-
-ROOT=${PWD}
-INTERNAL="internal/binutils internal/driver internal/elfexec internal/graph internal/report internal/symbolizer internal/symbolz"
-PACKAGES="profile ${INTERNAL}"
-
-echo Testing pprof packages at ${ROOT}
-GOPATH=${ROOT}:${ROOT}/third_party go test $PACKAGES
-RETCODE=$?
-
-if [ ${RETCODE} -eq 0 ]
-then
-   echo Tests were successful.
-else
-   echo Tests failed.
-fi

src/driver/driver.go → driver/driver.go

@@ -16,13 +16,13 @@
 package driver
 
 import (
-	internaldriver "internal/driver"
-	"internal/plugin"
 	"io"
 	"regexp"
 	"time"
 
-	"profile"
+	internaldriver "github.com/google/pprof/internal/driver"
+	"github.com/google/pprof/internal/plugin"
+	"github.com/google/pprof/profile"
 )
 
 // PProf acquires a profile, and symbolizes it using a profile

src/internal/binutils/addr2liner.go → internal/binutils/addr2liner.go

@@ -22,7 +22,7 @@ import (
 	"strconv"
 	"strings"
 
-	"internal/plugin"
+	"github.com/google/pprof/internal/plugin"
 )
 
 const (

src/internal/binutils/addr2liner_nm.go → internal/binutils/addr2liner_nm.go

@@ -22,7 +22,7 @@ import (
 	"strconv"
 	"strings"
 
-	"internal/plugin"
+	"github.com/google/pprof/internal/plugin"
 )
 
 const (

src/internal/binutils/binutils.go → internal/binutils/binutils.go

@@ -24,8 +24,8 @@ import (
 	"regexp"
 	"strings"
 
-	"internal/elfexec"
-	"internal/plugin"
+	"github.com/google/pprof/internal/elfexec"
+	"github.com/google/pprof/internal/plugin"
 )
 
 // A Binutils implements plugin.ObjTool by invoking the GNU binutils.

src/internal/binutils/binutils_test.go → internal/binutils/binutils_test.go

@@ -18,7 +18,7 @@ import (
 	"fmt"
 	"testing"
 
-	"internal/plugin"
+	"github.com/google/pprof/internal/plugin"
 )
 
 var testAddrMap = map[int]string{

src/internal/binutils/disasm.go → internal/binutils/disasm.go

@@ -22,8 +22,8 @@ import (
 	"regexp"
 	"strconv"
 
-	"internal/plugin"
-	"golang/demangle"
+	"github.com/google/pprof/internal/plugin"
+	"github.com/google/pprof/third_party/golang/demangle"
 )
 
 var (

src/internal/binutils/disasm_test.go → internal/binutils/disasm_test.go

@@ -19,7 +19,7 @@ import (
 	"regexp"
 	"testing"
 
-	"internal/plugin"
+	"github.com/google/pprof/internal/plugin"
 )
 
 // TestFindSymbols tests the FindSymbols routine by using a fake nm

src/internal/driver/cli.go → internal/driver/cli.go

@@ -19,8 +19,8 @@ import (
 	"os"
 	"strings"
 
-	"internal/binutils"
-	"internal/plugin"
+	"github.com/google/pprof/internal/binutils"
+	"github.com/google/pprof/internal/plugin"
 )
 
 type source struct {

src/internal/driver/commands.go → internal/driver/commands.go

@@ -26,10 +26,10 @@ import (
 	"strings"
 	"time"
 
-	"internal/plugin"
-	"internal/report"
-	"profile"
-	"svg"
+	"github.com/google/pprof/internal/plugin"
+	"github.com/google/pprof/internal/report"
+	"github.com/google/pprof/profile"
+	"github.com/google/pprof/third_party/svg"
 )
 
 // commands describes the commands accepted by pprof.

src/internal/driver/driver.go → internal/driver/driver.go

@@ -25,9 +25,9 @@ import (
 	"path/filepath"
 	"regexp"
 
-	"internal/plugin"
-	"profile"
-	"internal/report"
+	"github.com/google/pprof/internal/plugin"
+	"github.com/google/pprof/internal/report"
+	"github.com/google/pprof/profile"
 )
 
 // PProf acquires a profile, and symbolizes it using a profile

src/internal/driver/driver_focus.go → internal/driver/driver_focus.go

@@ -20,9 +20,9 @@ import (
 	"strconv"
 	"strings"
 
-	"internal/measurement"
-	"internal/plugin"
-	"profile"
+	"github.com/google/pprof/internal/measurement"
+	"github.com/google/pprof/internal/plugin"
+	"github.com/google/pprof/profile"
 )
 
 var tagFilterRangeRx = regexp.MustCompile("([[:digit:]]+)([[:alpha:]]+)")

src/internal/driver/driver_test.go → internal/driver/driver_test.go

@@ -24,11 +24,11 @@ import (
 	"testing"
 	"time"
 
-	"internal/binutils"
-	"internal/plugin"
-	"profile"
-	"internal/proftest"
-	"internal/symbolz"
+	"github.com/google/pprof/internal/binutils"
+	"github.com/google/pprof/internal/plugin"
+	"github.com/google/pprof/internal/proftest"
+	"github.com/google/pprof/internal/symbolz"
+	"github.com/google/pprof/profile"
 )
 
 func TestParse(t *testing.T) {

src/internal/driver/fetch.go → internal/driver/fetch.go

@@ -25,9 +25,9 @@ import (
 	"sync"
 	"time"
 
-	"internal/measurement"
-	"internal/plugin"
-	"profile"
+	"github.com/google/pprof/internal/measurement"
+	"github.com/google/pprof/internal/plugin"
+	"github.com/google/pprof/profile"
 )
 
 // fetchProfiles fetches and symbolizes the profiles specified by s.

src/internal/driver/fetch_test.go → internal/driver/fetch_test.go

@@ -25,9 +25,9 @@ import (
 	"testing"
 	"time"
 
-	"internal/plugin"
-	"internal/proftest"
-	"profile"
+	"github.com/google/pprof/internal/plugin"
+	"github.com/google/pprof/internal/proftest"
+	"github.com/google/pprof/profile"
 )
 
 func TestSymbolizationPath(t *testing.T) {

src/internal/driver/interactive.go → internal/driver/interactive.go

@@ -21,9 +21,9 @@ import (
 	"strconv"
 	"strings"
 
-	"internal/plugin"
-	"internal/report"
-	"profile"
+	"github.com/google/pprof/internal/plugin"
+	"github.com/google/pprof/internal/report"
+	"github.com/google/pprof/profile"
 )
 
 // interactive starts a shell to read pprof commands.

src/internal/driver/interactive_test.go → internal/driver/interactive_test.go

@@ -21,9 +21,9 @@ import (
 	"strings"
 	"testing"
 
-	"internal/plugin"
-	"profile"
-	"internal/report"
+	"github.com/google/pprof/internal/plugin"
+	"github.com/google/pprof/internal/report"
+	"github.com/google/pprof/profile"
 )
 
 func TestShell(t *testing.T) {

src/internal/driver/options.go → internal/driver/options.go

@@ -22,9 +22,9 @@ import (
 	"os"
 	"strings"
 
-	"internal/binutils"
-	"internal/plugin"
-	"internal/symbolizer"
+	"github.com/google/pprof/internal/binutils"
+	"github.com/google/pprof/internal/plugin"
+	"github.com/google/pprof/internal/symbolizer"
 )
 
 // setDefaults returns a new plugin.Options with zero fields sets to

src/internal/graph/dotgraph.go → internal/graph/dotgraph.go

@@ -21,7 +21,7 @@ import (
 	"path/filepath"
 	"strings"
 
-	"internal/measurement"
+	"github.com/google/pprof/internal/measurement"
 )
 
 // DotAttributes contains details about the graph itself, giving

src/internal/graph/dotgraph_test.go → internal/graph/dotgraph_test.go

@@ -23,7 +23,7 @@ import (
 	"strings"
 	"testing"
 
-	"internal/proftest"
+	"github.com/google/pprof/internal/proftest"
 )
 
 const path = "testdata/"

src/internal/graph/graph.go → internal/graph/graph.go

@@ -22,7 +22,7 @@ import (
 	"sort"
 	"strings"
 
-	"profile"
+	"github.com/google/pprof/profile"
 )
 
 // Graph summarizes a performance profile into a format that is

src/internal/measurement/measurement.go → internal/measurement/measurement.go

@@ -20,7 +20,7 @@ import (
 	"strings"
 	"time"
 
-	"profile"
+	"github.com/google/pprof/profile"
 )
 
 // ScaleProfiles updates the units in a set of profiles to make them

src/internal/plugin/plugin.go → internal/plugin/plugin.go

@@ -20,7 +20,7 @@ import (
 	"regexp"
 	"time"
 
-	"profile"
+	"github.com/google/pprof/profile"
 )
 
 // Options groups all the optional plugins into pprof.

src/internal/report/report.go → internal/report/report.go

@@ -28,10 +28,10 @@ import (
 	"strings"
 	"time"
 
-	"internal/graph"
-	"internal/measurement"
-	"internal/plugin"
-	"profile"
+	"github.com/google/pprof/internal/graph"
+	"github.com/google/pprof/internal/measurement"
+	"github.com/google/pprof/internal/plugin"
+	"github.com/google/pprof/profile"
 )
 
 // Generate generates a report as directed by the Report.

src/internal/report/report_test.go → internal/report/report_test.go

@@ -21,9 +21,9 @@ import (
 	"regexp"
 	"testing"
 
-	"internal/binutils"
-	"profile"
-	"internal/proftest"
+	"github.com/google/pprof/internal/binutils"
+	"github.com/google/pprof/internal/proftest"
+	"github.com/google/pprof/profile"
 )
 
 type testcase struct {

src/internal/report/source.go → internal/report/source.go

@@ -28,8 +28,8 @@ import (
 	"strconv"
 	"strings"
 
-	"internal/graph"
-	"internal/plugin"
+	"github.com/google/pprof/internal/graph"
+	"github.com/google/pprof/internal/plugin"
 )
 
 // printSource prints an annotated source listing, include all

src/internal/symbolizer/symbolizer.go → internal/symbolizer/symbolizer.go

@@ -24,11 +24,11 @@ import (
 	"path/filepath"
 	"strings"
 
-	"internal/binutils"
-	"internal/plugin"
-	"profile"
-	"internal/symbolz"
-	"golang/demangle"
+	"github.com/google/pprof/internal/binutils"
+	"github.com/google/pprof/internal/plugin"
+	"github.com/google/pprof/internal/symbolz"
+	"github.com/google/pprof/profile"
+	"github.com/google/pprof/third_party/golang/demangle"
 )
 
 // Symbolizer implements the plugin.Symbolize interface.

src/internal/symbolizer/symbolizer_test.go → internal/symbolizer/symbolizer_test.go

@@ -19,9 +19,9 @@ import (
 	"regexp"
 	"testing"
 
-	"internal/plugin"
-	"profile"
-	"internal/proftest"
+	"github.com/google/pprof/internal/plugin"
+	"github.com/google/pprof/internal/proftest"
+	"github.com/google/pprof/profile"
 )
 
 var testM = []*profile.Mapping{

src/internal/symbolz/symbolz.go → internal/symbolz/symbolz.go

@@ -26,8 +26,8 @@ import (
 	"strconv"
 	"strings"
 
-	"internal/plugin"
-	"profile"
+	"github.com/google/pprof/internal/plugin"
+	"github.com/google/pprof/profile"
 )
 
 var (

src/internal/symbolz/symbolz_test.go → internal/symbolz/symbolz_test.go

@@ -19,9 +19,9 @@ import (
 	"strings"
 	"testing"
 
-	"internal/plugin"
-	"profile"
-	"internal/proftest"
+	"github.com/google/pprof/internal/plugin"
+	"github.com/google/pprof/internal/proftest"
+	"github.com/google/pprof/profile"
 )
 
 func TestSymbolzURL(t *testing.T) {

src/pprof/pprof.go → pprof.go

@@ -20,7 +20,7 @@ import (
 	"fmt"
 	"os"
 
-	"driver"
+	"github.com/google/pprof/driver"
 )
 
 func main() {

src/profile/profile_test.go → profile/profile_test.go

@@ -23,7 +23,7 @@ import (
 	"regexp"
 	"testing"
 
-	"internal/proftest"
+	"github.com/google/pprof/internal/proftest"
 )
 
 func TestParse(t *testing.T) {

src/profile/proto_test.go → profile/proto_test.go

@@ -18,7 +18,7 @@ import (
 	"bytes"
 	"testing"
 
-	"internal/proftest"
+	"github.com/google/pprof/internal/proftest"
 )
 
 var testM = []*Mapping{